Home
# Review: DialRush control layer for the bot, jg-dialer-bot commit 9aeb945
Reviewer: Fable reviewer thread, Nov 19 2026. Read cold, read only. No rewrites made.
Read: app/dialrush/guard.py, app/dr_tools.py, the safety paths of app/dialrush/client.py (match, seats, click, submit, create, generate, activate, assign), and the diffs to agent.py, bot.py, tools.py, config.yaml.
Verdict: NOT PASSED. Keep it off (DIALER_BACKEND unset) and unmerged. Nothing here is switched on by the commit.
## Rules that hold
- Off unless DIALER_BACKEND=dialrush. With it unset, the bot's behaviour does not change.
- No delete or remove-user function exists.
- Elite is checked in three places (tool, client, create) before any page opens.
- Create, deactivate and reactivate always wait for a Confirm that only the asker can press, once, within 5 minutes.
- One change at a time is enforced with no gap between the check and the lock.
- The request gate blocks every non-read request outside a change, and never lets one through to a billing, seats, upload or delete address.
- Logs and the log channel carry counts and a code word. The login is masked.
- Write rights reuse ctx.can_write.
## Changes, most important first
1. **Over 10 people is the asker's yes, not Julian's.** The project rule is that a change to more than 10 people waits for Julian's yes. Here the model sets bulk_yes when the asker says yes, and the asker then presses their own Confirm. Either refuse over 10 outright, the same way Elite is refused, or let only Julian's Discord id press that Confirm. Also note that three requests of 10 pass today. Count people per asker over a time window.
2. **Reactivate and create can still cost a seat.** Reactivate has no open-seat check at all. Create reads the seat count with guessed field names (the file says so), and the fallback "total minus used" accepts loose names such as "active" and "seats", so a wrong guess can report an open seat that is not there. After that, the bot presses any box with Confirm, Yes, Deactivate or Reactivate on it without reading what the box says. If DialRush asks "this adds a seat to your plan, confirm?", the bot confirms. Read the box's text and refuse if it mentions a seat, a charge, a plan or billing. Check open seats before reactivate. Accept only field names seen on the real page.
3. **A close name acts on a different person.** match_users falls back to names that are 85 percent alike, and when only one is close it is used without asking. The roster has pairs of real people whose names differ by one letter. For a single-agent playlist change there is no Confirm, so a typo moves the wrong agent straight away. A non-exact match should always come back as needs_choice ("did you mean ...").
4. **The Elite test misses some names.** The pattern needs a word edge on both sides, so "Elite2", "Elite_A" and "EliteLeads" pass as not Elite. Match the letters "elite" anywhere, and accept that "Eliteness" is refused too.
5. **A stop in the middle of a batch reports nothing done.** In _work, a Forbidden or any error that is not a DialRushError leaves the loop by raising. _call then returns only an error, the card says "Not done", and no audit line is written, even when earlier people in the batch were already changed. Catch it in the loop, keep the done list, and write the audit line every time.
6. **Write clicks are guarded by a deny list only.** Any label that is not on the forbidden list can be pressed with the gate open. With unverified selectors, a wrong match (for example a different menu item that contains the word Deactivate) would go through. For clicks that open the gate, allow only the exact labels the bot means to press.
7. **Screenshots.** _shot skips only the sign-in page. After Generate the new password is on screen. An error screenshot there would capture it. Skip the screenshot whenever the Add someone result is showing.
8. **Refused-click log line holds the label.** The label can contain a person's name. Log the reason, not the label.
9. **Tested against a fake page written with the code.** This is the same lesson as the 5+ minute feed. Before switching on: one dry run on the real DialRush with Julian signed in, every selector marked unverified checked, and the seat summary's real shape recorded.
## Not checked
I did not run the tests (the Python browser package is not installed here) and did not see a passing run. I did not read tests/ line by line, selectors.yaml in full, or the rename, move, remove-from-playlist and playlist-info paths in the client. No live DialRush page was opened.
## Merge
This repo deploys the live bot on Railway. Even when this passes review, the merge needs Julian's own yes, and switching it on is a DialRush change that needs his yes as well.